don't invoke response block more than once due to retry#87
Closed
jstanley0 wants to merge 1 commit intoruby:masterfrom
Closed
don't invoke response block more than once due to retry#87jstanley0 wants to merge 1 commit intoruby:masterfrom
jstanley0 wants to merge 1 commit intoruby:masterfrom
Conversation
If a socket error occurs while performing a streaming download via the response block provided to transport_request, avoid calling the response block again as this would result in duplicate data received by the client. fixes ruby#86
jeremyevans
approved these changes
Aug 22, 2023
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
It would be good if this added tests, but regardless I think it should be committed. This fixes Ruby Bug #11526.
Member
|
@jeremyevans You can merge this if you provide a test |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 5, 2024
If a socket error occurs while performing a streaming download via the response block provided to transport_request, avoid calling the response block again as this would result in duplicate data received by the client. Fixes ruby/net-http#86 Fixes ruby/net-http#87 Fixes [Bug #11526] ruby/net-http@114d01b092 Co-authored-by: Jeremy Stanley <jeremy@instructure.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a socket error occurs while performing a streaming download via the response block provided to transport_request, avoid calling the response block again as this would result in duplicate data received by the client.
fixes #86